test: make validate_parse more python3 friendly#32688
Merged
compnerd merged 2 commits intoswiftlang:masterfrom Jul 4, 2020
Merged
test: make validate_parse more python3 friendly#32688compnerd merged 2 commits intoswiftlang:masterfrom
validate_parse more python3 friendly#32688compnerd merged 2 commits intoswiftlang:masterfrom
Conversation
Use `io.open` to open the files with the correct encoding and to allow proper newline specification. This allows the script to be python 2 and python 3 compatible.
Member
Author
|
@swift-ci please test |
Member
Author
Contributor
|
Build failed |
Member
Author
|
@swift-ci please test macOS platform |
Member
Author
|
@swift-ci please test Windows platform |
Contributor
|
Build failed |
Attempt to appease the python linter
Member
Author
|
@swift-ci please python lint |
Member
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Member
Author
|
@swift-ci please test windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
io.opento open the files with the correct encoding and to allowproper newline specification. This allows the script to be python 2 and
python 3 compatible.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.